[DataFrame] - Add union and union_distinct bindings for DataFrame #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Aug 18, 2022
| /// Calculate the union of two `DataFrame`s, preserving duplicate rows.The | ||
| /// two `DataFrame`s must have exactly the same schema | ||
| #[args(distinct = false)] | ||
| fn union(&self, py_df: PyDataFrame, distinct: bool) -> PyResult<Self> { |
There was a problem hiding this comment.
It seems confusing to me to have a distinct parameter to this method.
There was a problem hiding this comment.
When df.union(df,distinct=true), it has the same function as df.union_distinct(df)
There was a problem hiding this comment.
Then do we need both functions?
There was a problem hiding this comment.
User has two ways to use union distinct, if not necessary I will remove parameter district from union.
francis-du
force-pushed
the
df_union_fun
branch
from
c52799c to
c4bfc69
Compare
francis-du
force-pushed
the
df_union_fun
branch
2 times, most recently
from
7a9183f to
73d750f
Compare
francis-du
force-pushed
the
df_union_fun
branch
from
73d750f to
b7d87b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #25